feat(django): explicitically define on_delete for ForeignKey fields for 2.0 compat

Also define all owner fields as PROTECT instead of delete see https://docs.djangoproject.com/en/1.9/ref/models/fields/#django.db.models.ForeignKey

https://docs.djangoproject.com/en/1.9/releases/1.9/#foreignkey-and-onetoonefield-on-delete-argument

Author: helgi

rootfs/api/migrations/0009_auto_20160607_2259.py

@@ -0,0 +1,57 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.9.6 on 2016-06-07 22:59
+from __future__ import unicode_literals
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('api', '0008_config_registry'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='app',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='build',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='certificate',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='config',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='domain',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='key',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='push',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='release',
+            name='owner',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+        ),
+    ]

rootfs/api/models/app.py

@@ -62,7 +62,7 @@ class App(UuidAuditedModel):
     Application used to service requests on behalf of end-users
     """
 
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
     id = models.SlugField(max_length=24, unique=True, null=True,
                           validators=[validate_id_is_docker_compatible,
                                       validate_reserved_names])

rootfs/api/models/build.py

@@ -13,8 +13,8 @@ class Build(UuidAuditedModel):
     Instance of a software build used by runtime nodes
     """
 
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
-    app = models.ForeignKey('App')
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    app = models.ForeignKey('App', on_delete=models.CASCADE)
     image = models.TextField()
 
     # optional fields populated by builder

rootfs/api/models/certificate.py

@@ -74,7 +74,7 @@ class Certificate(AuditedModel):
     """
     Public and private key pair used to secure application traffic at the router.
     """
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
     name = models.CharField(max_length=253, unique=True, validators=[validate_label])
     # there is no upper limit on the size of an x.509 certificate
     certificate = models.TextField(validators=[validate_certificate])

rootfs/api/models/config.py

@@ -12,8 +12,8 @@ class Config(UuidAuditedModel):
     during runtime execution of the Application.
     """
 
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
-    app = models.ForeignKey('App')
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    app = models.ForeignKey('App', on_delete=models.CASCADE)
     values = JSONField(default={}, blank=True)
     memory = JSONField(default={}, blank=True)
     cpu = JSONField(default={}, blank=True)

rootfs/api/models/domain.py

@@ -5,12 +5,12 @@
 
 
 class Domain(AuditedModel):
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
-    app = models.ForeignKey('App')
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    app = models.ForeignKey('App', on_delete=models.CASCADE)
     domain = models.TextField(blank=False, null=False, unique=True)
     certificate = models.ForeignKey(
         'Certificate',
-        models.SET_NULL,
+        on_delete=models.SET_NULL,
         blank=True,
         null=True
     )

rootfs/api/models/key.py

@@ -19,7 +19,7 @@ def validate_base64(value):
 class Key(UuidAuditedModel):
     """An SSH public key."""
 
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.CASCADE)
     id = models.CharField(max_length=128)
     public = models.TextField(unique=True, validators=[validate_base64])
     fingerprint = models.CharField(max_length=128, editable=False)

rootfs/api/models/push.py

@@ -8,8 +8,8 @@ class Push(UuidAuditedModel):
     """
     Instance of a push used to trigger an application build
     """
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
-    app = models.ForeignKey('App')
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    app = models.ForeignKey('App', on_delete=models.CASCADE)
     sha = models.CharField(max_length=40)
 
     fingerprint = models.CharField(max_length=255)

rootfs/api/models/release.py

@@ -18,13 +18,13 @@ class Release(UuidAuditedModel):
     Releases contain a :class:`Build` and a :class:`Config`.
     """
 
-    owner = models.ForeignKey(settings.AUTH_USER_MODEL)
-    app = models.ForeignKey('App')
+    owner = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    app = models.ForeignKey('App', on_delete=models.CASCADE)
     version = models.PositiveIntegerField()
     summary = models.TextField(blank=True, null=True)
 
-    config = models.ForeignKey('Config')
-    build = models.ForeignKey('Build', null=True)
+    config = models.ForeignKey('Config', on_delete=models.CASCADE)
+    build = models.ForeignKey('Build', null=True, on_delete=models.CASCADE)
 
     class Meta:
         get_latest_by = 'created'