Skip to content

Commit eaea3d1

Browse files
committed
fix(docker): always use ":latest" tag in docker pull
Now that the Docker Index allows tagged builds directly from GitHub project tags, we will version Deis components properly as deis/controller:v0.9.0 rather than deisreleases/controller-v0.9.0. At that point, doing a plain "docker pull deis/controller" will pull down all tagged images when we only wanted one, so this change prevents users from wasting more time on already slow download operations. Being explicit about the docker image tag also facilitates our release process.
1 parent dd29a02 commit eaea3d1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

systemd/deis-controller.service

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ After=deis-logger.service
66
[Service]
77
EnvironmentFile=/etc/environment
88
TimeoutStartSec=20m
9-
ExecStartPre=/bin/sh -c "docker history deis/controller >/dev/null || docker pull deis/controller"
9+
ExecStartPre=/bin/sh -c "docker history deis/controller >/dev/null || docker pull deis/controller:latest"
1010
ExecStartPre=/bin/sh -c "docker inspect deis-controller >/dev/null && docker rm -f deis-controller || true"
1111
ExecStart=/usr/bin/docker run --name deis-controller -p 8000:8000 -e PUBLISH=8000 -e HOST=${COREOS_PRIVATE_IPV4} --volumes-from=deis-logger deis/controller
1212
ExecStop=/usr/bin/docker rm -f deis-controller

0 commit comments

Comments
 (0)