fix(errors): parse newlines in unknown errors (#76)

Author: Joshua-Anderson

errors.go

@@ -253,6 +253,8 @@ func arrayContains(search string, completeMatch bool, array []string) bool {
 }
 
 func unknownServerError(statusCode int, message string) error {
+	// newlines set from controller aren't evaluated as controller characters, so they need to be replaced
+	message = strings.Replace(message, `\n`, "\n", -1)
 	return fmt.Errorf(formatErrUnknown, statusCode, message)
 }
 

errors_test.go

@@ -275,9 +275,10 @@ func TestErrors(t *testing.T) {
 		{
 			res: &http.Response{
 				StatusCode: 400,
-				Body:       readCloser(`{"detail":"unknown error"}`),
+				Body:       readCloser(`{"detail":"unknown error\nnewline"}`),
 			},
-			expected: errors.New(`Unknown Error (400): {"detail":"unknown error"}`),
+			expected: errors.New(`Unknown Error (400): {"detail":"unknown error
+newline"}`),
 		},
 	}