chore(maintenance): remove maintenance support

Author: duanhongyi

api/appsettings.go

@@ -18,8 +18,6 @@ type AppSettings struct {
 	// UUID is a unique string reflecting the application settings in its current state.
 	// It changes every time the application settings is changed and cannot be updated.
 	UUID string `json:"uuid,omitempty"`
-	// Maintenance determines if the application is taken down for maintenance or not.
-	Maintenance *bool `json:"maintenance,omitempty"`
 	// Routable determines if the application should be exposed by the router.
 	Routable  *bool                 `json:"routable,omitempty"`
 	Whitelist []string              `json:"whitelist,omitempty"`

appsettings/appsettings_test.go

@@ -16,7 +16,6 @@ const appSettingsFixture string = `
 {
     "owner": "test",
     "app": "example-go",
-    "maintenance": true,
     "routable": true,
     "whitelist": ["1.2.3.4", "0.0.0.0/0"],
     "autoscale": {"cmd": {"min": 3, "max": 8, "cpu_percent": 40}},
@@ -31,7 +30,6 @@ const appSettingsUnsetFixture string = `
 {
     "owner": "test",
     "app": "unset-test",
-    "maintenance": true,
     "routable": true,
     "whitelist": ["1.2.3.4", "0.0.0.0/0"],
     "autoscale": {"cmd": {"min": 3, "max": 8, "cpu_percent": 40}},
@@ -42,10 +40,8 @@ const appSettingsUnsetFixture string = `
 }
 `
 
-const appSettingsSetExpected string = `{"maintenance":true,"routable":true,"whitelist":["1.2.3.4","0.0.0.0/0"],"autoscale":{"cmd":{"min":3,"max":8,"cpu_percent":40}},"label":{"git_repo":"https://github.com/drycc/controller-sdk-go","team":"drycc"}}`
-const appSettingsUnsetExpected string = `{"maintenance":true,"routable":true,"whitelist":["1.2.3.4","0.0.0.0/0"],"autoscale":{"cmd":{"min":3,"max":8,"cpu_percent":40}},"label":{"git_repo":"https://github.com/drycc/controller-sdk-go","team":"drycc"}}`
-
-var trueVar = true
+const appSettingsSetExpected string = `{"routable":true,"whitelist":["1.2.3.4","0.0.0.0/0"],"autoscale":{"cmd":{"min":3,"max":8,"cpu_percent":40}},"label":{"git_repo":"https://github.com/drycc/controller-sdk-go","team":"drycc"}}`
+const appSettingsUnsetExpected string = `{"routable":true,"whitelist":["1.2.3.4","0.0.0.0/0"],"autoscale":{"cmd":{"min":3,"max":8,"cpu_percent":40}},"label":{"git_repo":"https://github.com/drycc/controller-sdk-go","team":"drycc"}}`
 
 type fakeHTTPServer struct{}
 
@@ -94,22 +90,11 @@ func (f *fakeHTTPServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {
 		return
 	}
 
-	if req.URL.Path == "/v2/apps/invalidjson-test/settings/" && req.Method == "POST" {
-		res.WriteHeader(http.StatusCreated)
-		res.Write([]byte(`"maintenance": "test"`))
-		return
-	}
-
 	if req.URL.Path == "/v2/apps/example-go/settings/" && req.Method == "GET" {
 		res.Write([]byte(appSettingsFixture))
 		return
 	}
 
-	if req.URL.Path == "/v2/apps/invalidjson-test/settings/" && req.Method == "GET" {
-		res.Write([]byte(`"maintenance": "test"`))
-		return
-	}
-
 	fmt.Printf("Unrecognized URL %s\n", req.URL)
 	res.WriteHeader(http.StatusNotFound)
 	res.Write(nil)
@@ -128,11 +113,10 @@ func TestAppSettingsSet(t *testing.T) {
 	}
 
 	expected := api.AppSettings{
-		Owner:       "test",
-		App:         "example-go",
-		Routable:    api.NewRoutable(),
-		Maintenance: &trueVar,
-		Whitelist:   []string{"1.2.3.4", "0.0.0.0/0"},
+		Owner:     "test",
+		App:       "example-go",
+		Routable:  api.NewRoutable(),
+		Whitelist: []string{"1.2.3.4", "0.0.0.0/0"},
 		Autoscale: map[string]*api.Autoscale{
 			"cmd": {
 				Min:        3,
@@ -150,9 +134,8 @@ func TestAppSettingsSet(t *testing.T) {
 	}
 
 	appSettingsVars := api.AppSettings{
-		Maintenance: &trueVar,
-		Routable:    api.NewRoutable(),
-		Whitelist:   []string{"1.2.3.4", "0.0.0.0/0"},
+		Routable:  api.NewRoutable(),
+		Whitelist: []string{"1.2.3.4", "0.0.0.0/0"},
 		Autoscale: map[string]*api.Autoscale{
 			"cmd": {
 				Min:        3,
@@ -190,11 +173,10 @@ func TestAppSettingsUnset(t *testing.T) {
 	}
 
 	expected := api.AppSettings{
-		Owner:       "test",
-		App:         "unset-test",
-		Maintenance: &trueVar,
-		Routable:    api.NewRoutable(),
-		Whitelist:   []string{"1.2.3.4", "0.0.0.0/0"},
+		Owner:     "test",
+		App:       "unset-test",
+		Routable:  api.NewRoutable(),
+		Whitelist: []string{"1.2.3.4", "0.0.0.0/0"},
 		Autoscale: map[string]*api.Autoscale{
 			"cmd": {
 				Min:        3,
@@ -212,9 +194,8 @@ func TestAppSettingsUnset(t *testing.T) {
 	}
 
 	appSettingsVars := api.AppSettings{
-		Maintenance: &trueVar,
-		Routable:    api.NewRoutable(),
-		Whitelist:   []string{"1.2.3.4", "0.0.0.0/0"},
+		Routable:  api.NewRoutable(),
+		Whitelist: []string{"1.2.3.4", "0.0.0.0/0"},
 		Autoscale: map[string]*api.Autoscale{
 			"cmd": {
 				Min:        3,
@@ -252,11 +233,10 @@ func TestAppSettingsList(t *testing.T) {
 	}
 
 	expected := api.AppSettings{
-		Owner:       "test",
-		App:         "example-go",
-		Maintenance: &trueVar,
-		Routable:    api.NewRoutable(),
-		Whitelist:   []string{"1.2.3.4", "0.0.0.0/0"},
+		Owner:     "test",
+		App:       "example-go",
+		Routable:  api.NewRoutable(),
+		Whitelist: []string{"1.2.3.4", "0.0.0.0/0"},
 		Autoscale: map[string]*api.Autoscale{
 			"cmd": {
 				Min:        3,
@@ -283,30 +263,3 @@ func TestAppSettingsList(t *testing.T) {
 		t.Errorf("Expected %v, Got %v", expected, actual)
 	}
 }
-
-func TestAppSettingsInvalidJson(t *testing.T) {
-	t.Parallel()
-
-	handler := fakeHTTPServer{}
-	server := httptest.NewServer(&handler)
-	defer server.Close()
-
-	drycc, err := drycc.New(false, server.URL, "abc")
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	_, err = List(drycc, "invalidjson-test")
-	expected := "json: cannot unmarshal string into Go value of type api.AppSettings"
-	if err == nil || !reflect.DeepEqual(expected, err.Error()) {
-		t.Errorf("Expected %v, Got %v", expected, err)
-	}
-
-	appSettingsVars := api.AppSettings{
-		Maintenance: &trueVar,
-	}
-	_, err = Set(drycc, "invalidjson-test", appSettingsVars)
-	if err == nil || !reflect.DeepEqual(expected, err.Error()) {
-		t.Errorf("Expected %v, Got %v", expected, err)
-	}
-}