ref(*): rewrite to use path/filepath for better OS compatibility

Author: Joshua-Anderson

client/client.go

@@ -7,7 +7,7 @@ import (
 	"net/http"
 	"net/url"
 	"os"
-	"path"
+	"path/filepath"
 )
 
 // Client oversees the interaction between the client and controller
@@ -94,7 +94,7 @@ func (c Client) Save() error {
 		return err
 	}
 
-	if err = os.MkdirAll(path.Join(FindHome(), "/.deis/"), 0775); err != nil {
+	if err = os.MkdirAll(filepath.Join(FindHome(), "/.deis/"), 0775); err != nil {
 		return err
 	}
 

client/client_test.go

@@ -4,7 +4,7 @@ import (
 	"io/ioutil"
 	"net/url"
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 )
 
@@ -19,12 +19,12 @@ func createTempProfile(contents string) error {
 
 	os.Unsetenv("DEIS_PROFILE")
 	os.Setenv("HOME", name)
-	folder := path.Join(name, "/.deis/")
+	folder := filepath.Join(name, ".deis")
 	if err = os.Mkdir(folder, 0755); err != nil {
 		return err
 	}
 
-	if err = ioutil.WriteFile(path.Join(folder, "client.json"), []byte(contents), 0775); err != nil {
+	if err = ioutil.WriteFile(filepath.Join(folder, "client.json"), []byte(contents), 0775); err != nil {
 		return err
 	}
 

client/utils.go

@@ -3,7 +3,7 @@ package client
 import (
 	"fmt"
 	"os"
-	"path"
+	"path/filepath"
 
 	"github.com/deis/workflow-cli/version"
 )
@@ -15,7 +15,7 @@ func locateSettingsFile() string {
 		filename = "client"
 	}
 
-	return path.Join(FindHome(), ".deis", filename+".json")
+	return filepath.Join(FindHome(), ".deis", filename+".json")
 }
 
 func checkAPICompatibility(serverAPIVersion string) {

client/utils_test.go

@@ -1,3 +1,5 @@
+// +build linux darwin
+
 package client
 
 import (