Skip to content

Commit b8db18d

Browse files
author
Matthew Fisher
committed
Merge pull request #1992 from bacongobbler/logspout
feat(logspout): introduce deis/logspout
2 parents 441d218 + b087c86 commit b8db18d

1 file changed

Lines changed: 4 additions & 32 deletions

File tree

scheduler/coreos.py

Lines changed: 4 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import cStringIO
22
import base64
33
import copy
4-
import functools
54
import json
65
import httplib
76
import paramiko
@@ -105,7 +104,6 @@ def create(self, name, image, command='', template=None, **kwargs):
105104
"""Create a container"""
106105
self._create_container(name, image, command,
107106
template or copy.deepcopy(CONTAINER_TEMPLATE), **kwargs)
108-
self._create_log(name, image, command, copy.deepcopy(LOG_TEMPLATE))
109107

110108
def _create_container(self, name, image, command, unit, **kwargs):
111109
l = locals().copy()
@@ -138,15 +136,6 @@ def _create_container(self, name, image, command, unit, **kwargs):
138136
# post unit to fleet
139137
self._put_unit(name, {"desiredState": "launched", "options": unit})
140138

141-
def _create_log(self, name, image, command, unit):
142-
l = locals().copy()
143-
l.update(re.match(MATCH, name).groupdict())
144-
# construct unit from template
145-
for f in unit:
146-
f['value'] = f['value'].format(**l)
147-
# post unit to fleet
148-
self._put_unit(name+'-log', {"desiredState": "launched", "options": unit})
149-
150139
def start(self, name):
151140
"""Start a container"""
152141
self._wait_for_container(name)
@@ -181,23 +170,16 @@ def stop(self, name):
181170

182171
def destroy(self, name):
183172
"""Destroy a container"""
184-
funcs = []
185-
funcs.append(functools.partial(self._destroy_container, name))
186-
funcs.append(functools.partial(self._destroy_log, name))
187173
# call all destroy functions, ignoring any errors
188-
for f in funcs:
189-
try:
190-
f()
191-
except:
192-
pass
174+
try:
175+
self._destroy_container(name)
176+
except:
177+
pass
193178
self._wait_for_destroy(name)
194179

195180
def _destroy_container(self, name):
196181
return self._delete_unit(name)
197182

198-
def _destroy_log(self, name):
199-
return self._delete_unit(name+'-log')
200-
201183
def run(self, name, image, entrypoint, command): # noqa
202184
"""Run a one-off command"""
203185
self._create_container(name, image, command, copy.deepcopy(RUN_TEMPLATE),
@@ -309,16 +291,6 @@ def attach(self, name):
309291
]
310292

311293

312-
LOG_TEMPLATE = [
313-
{"section": "Unit", "name": "Description", "value": "{name} log"},
314-
{"section": "Unit", "name": "BindsTo", "value": "{name}.service"},
315-
{"section": "Service", "name": "ExecStartPre", "value": '''/bin/sh -c "until docker inspect {name} >/dev/null 2>&1; do sleep 1; done"'''}, # noqa
316-
{"section": "Service", "name": "ExecStart", "value": '''/bin/sh -c "docker logs -f {name} 2>&1 | logger -p local0.info -t {app}[{c_type}.{c_num}] --udp --server $(etcdctl get /deis/logs/host) --port $(etcdctl get /deis/logs/port)"'''}, # noqa
317-
{"section": "Service", "name": "TimeoutStartSec", "value": "20m"},
318-
{"section": "X-Fleet", "name": "MachineOf", "value": "{name}.service"},
319-
]
320-
321-
322294
RUN_TEMPLATE = [
323295
{"section": "Unit", "name": "Description", "value": "{name} admin command"},
324296
{"section": "Service", "name": "ExecStartPre", "value": '''/bin/sh -c "IMAGE=$(etcdctl get /deis/registry/host 2>&1):$(etcdctl get /deis/registry/port 2>&1)/{image}; docker pull $IMAGE"'''}, # noqa

0 commit comments

Comments
 (0)