feat(build): add get build api

Author: duanhongyi

builds/builds.go

@@ -9,55 +9,31 @@ import (
 	"github.com/drycc/controller-sdk-go/api"
 )
 
-// List lists an app's builds.
-func List(c *drycc.Client, appID string, results int) ([]api.Build, int, error) {
-	u := fmt.Sprintf("/v2/apps/%s/builds/", appID)
-	body, count, reqErr := c.LimitedRequest(u, results)
+// Get a build of an app.
+func Get(c *drycc.Client, appID string, version int) (api.Build, error) {
+	u := fmt.Sprintf("/v2/apps/%s/build/", appID)
+	if version > 0 {
+		u = fmt.Sprintf("%s?version=v%d", u, version)
+	}
 
+	res, reqErr := c.Request("GET", u, nil)
 	if reqErr != nil && !drycc.IsErrAPIMismatch(reqErr) {
-		return []api.Build{}, -1, reqErr
+		return api.Build{}, reqErr
 	}
+	defer res.Body.Close()
 
-	var builds []api.Build
-	if err := json.Unmarshal([]byte(body), &builds); err != nil {
-		return []api.Build{}, -1, err
+	var build api.Build
+	if err := json.NewDecoder(res.Body).Decode(&build); err != nil {
+		return api.Build{}, err
 	}
-
-	return builds, count, reqErr
+	return build, reqErr
 }
 
-// New creates a build for an app from an container image.
-// By default this will create a cmd process that runs the CMD command from the Dockerfile.
-// If you want to define more process types, you can pass a Procfile map,
-// where the key is the process name and the value is the command for that process.
-// To pull from a private container registry, a custom username and password must be set in the app's
-// configuration object. This can be done with `drycc registry:set` or by using this SDK.
-//
-// This example adds custom registry credentials to an app:
-//
-//	import (
-//		"github.com/drycc/controller-sdk-go/api"
-//		"github.com/drycc/controller-sdk-go/config"
-//	)
-//
-//	// Create username/password map
-//	registryMap := map[string]string{
-//		"username": "password"
-//	}
-//
-//	// Create a new configuration, assign the credentials, and set it.
-//	// Note that config setting is a patching operation, it doesn't overwrite or unset
-//	// unrelated configuration.
-//	newConfig := api.Config{}
-//	newConfig.Registry = registryMap
-//	_, err := config.Set(<client>, "appname", newConfig)
-//	if err != nil {
-//	    log.Fatal(err)
-//	}
+// New a build of an app.
 func New(c *drycc.Client, appID string, image string, stack string,
 	procfile map[string]string, dryccfile map[string]interface{}) (api.Build, error) {
 
-	u := fmt.Sprintf("/v2/apps/%s/builds/", appID)
+	u := fmt.Sprintf("/v2/apps/%s/build/", appID)
 
 	req := api.CreateBuildRequest{
 		Image:     image,

builds/builds_test.go

@@ -14,26 +14,19 @@ import (
 
 const buildsFixture string = `
 {
-    "count": 1,
-    "next": null,
-    "previous": null,
-    "results": [
-        {
-            "app": "example-go",
-            "created": "2014-01-01T00:00:00UTC",
-            "dockerfile": "FROM drycc/slugrunner RUN mkdir -p /app WORKDIR /app ENTRYPOINT [\"/runner/init\"] ADD slug.tgz /app ENV GIT_SHA 060da68f654e75fac06dbedd1995d5f8ad9084db",
-            "image": "example-go",
-            "stack": "container",
-            "owner": "test",
-            "procfile": {
-                "web": "example-go"
-            },
-			"dryccfile": {},
-            "sha": "060da68f",
-            "updated": "2014-01-01T00:00:00UTC",
-            "uuid": "de1bf5b5-4a72-4f94-a10c-d2a3741cdf75"
-        }
-    ]
+	"app": "example-go",
+	"created": "2014-01-01T00:00:00UTC",
+	"dockerfile": "FROM drycc/slugrunner RUN mkdir -p /app WORKDIR /app ENTRYPOINT [\"/runner/init\"] ADD slug.tgz /app ENV GIT_SHA 060da68f654e75fac06dbedd1995d5f8ad9084db",
+	"image": "example-go",
+	"stack": "container",
+	"owner": "test",
+	"procfile": {
+		"web": "example-go"
+	},
+	"dryccfile": {},
+	"sha": "060da68f",
+	"updated": "2014-01-01T00:00:00UTC",
+	"uuid": "de1bf5b5-4a72-4f94-a10c-d2a3741cdf75"
 }`
 
 const buildFixture string = `
@@ -60,12 +53,12 @@ type fakeHTTPServer struct{}
 func (fakeHTTPServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {
 	res.Header().Add("DRYCC_API_VERSION", drycc.APIVersion)
 
-	if req.URL.Path == "/v2/apps/example-go/builds/" && req.Method == "GET" {
+	if req.URL.Path == "/v2/apps/example-go/build/" && req.Method == "GET" {
 		res.Write([]byte(buildsFixture))
 		return
 	}
 
-	if req.URL.Path == "/v2/apps/example-go/builds/" && req.Method == "POST" {
+	if req.URL.Path == "/v2/apps/example-go/build/" && req.Method == "POST" {
 		body, err := io.ReadAll(req.Body)
 
 		if err != nil {
@@ -91,23 +84,21 @@ func (fakeHTTPServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {
 	res.Write(nil)
 }
 
-func TestBuildsList(t *testing.T) {
+func TestBuildsGet(t *testing.T) {
 	t.Parallel()
 
-	expected := []api.Build{
-		{
-			App:        "example-go",
-			Created:    "2014-01-01T00:00:00UTC",
-			Dockerfile: "FROM drycc/slugrunner RUN mkdir -p /app WORKDIR /app ENTRYPOINT [\"/runner/init\"] ADD slug.tgz /app ENV GIT_SHA 060da68f654e75fac06dbedd1995d5f8ad9084db",
-			Image:      "example-go",
-			Stack:      "container",
-			Owner:      "test",
-			Procfile:   map[string]string{"web": "example-go"},
-			Dryccfile:  map[string]interface{}{},
-			Sha:        "060da68f",
-			Updated:    "2014-01-01T00:00:00UTC",
-			UUID:       "de1bf5b5-4a72-4f94-a10c-d2a3741cdf75",
-		},
+	expected := api.Build{
+		App:        "example-go",
+		Created:    "2014-01-01T00:00:00UTC",
+		Dockerfile: "FROM drycc/slugrunner RUN mkdir -p /app WORKDIR /app ENTRYPOINT [\"/runner/init\"] ADD slug.tgz /app ENV GIT_SHA 060da68f654e75fac06dbedd1995d5f8ad9084db",
+		Image:      "example-go",
+		Stack:      "container",
+		Owner:      "test",
+		Procfile:   map[string]string{"web": "example-go"},
+		Dryccfile:  map[string]interface{}{},
+		Sha:        "060da68f",
+		Updated:    "2014-01-01T00:00:00UTC",
+		UUID:       "de1bf5b5-4a72-4f94-a10c-d2a3741cdf75",
 	}
 
 	handler := fakeHTTPServer{}
@@ -119,7 +110,7 @@ func TestBuildsList(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	actual, _, err := List(drycc, "example-go", 100)
+	actual, err := Get(drycc, "example-go", -1)
 
 	if err != nil {
 		t.Fatal(err)