fix(deis): rename DeisVersion to ControllerVersion and set it in all requests (#93)

Author: Joshua-Anderson

deis.go

@@ -77,8 +77,8 @@ type Client struct {
 	// API Version used by the controller, set after a http request.
 	ControllerAPIVersion string
 
-	// Version of the deis platform in use, set after a http request.
-	DeisVersion string
+	// Version of the deis controller in use, set after a http request.
+	ControllerVersion string
 
 	// Token is used to authenticate the request against the API.
 	Token string

http.go

@@ -67,7 +67,7 @@ func (c *Client) Request(method string, path string, body []byte) (*http.Respons
 
 	// Update controller api and platform version
 	c.ControllerAPIVersion = apiVersion
-	c.DeisVersion = res.Header.Get("DEIS_PLATFORM_VERSION")
+	setControllerVersion(c, res.Header)
 
 	// Return results along with api compatibility error
 	return res, checkAPICompatibility(apiVersion, APIVersion)
@@ -131,6 +131,7 @@ your deis version is correct.`
 	// Update controller api version
 	apiVersion := res.Header.Get("DEIS_API_VERSION")
 	c.ControllerAPIVersion = apiVersion
+	setControllerVersion(c, res.Header)
 
 	return checkAPICompatibility(apiVersion, APIVersion)
 }
@@ -159,10 +160,15 @@ func (c *Client) Healthcheck() error {
 	// Update controller api version
 	apiVersion := res.Header.Get("DEIS_API_VERSION")
 	c.ControllerAPIVersion = apiVersion
+	setControllerVersion(c, res.Header)
 
 	return checkAPICompatibility(apiVersion, APIVersion)
 }
 
 func addUserAgent(headers *http.Header, userAgent string) {
 	headers.Add("User-Agent", userAgent)
 }
+
+func setControllerVersion(c *Client, headers http.Header) {
+	c.ControllerVersion = headers.Get("DEIS_PLATFORM_VERSION")
+}

http_test.go

@@ -179,8 +179,8 @@ func TestBasicRequest(t *testing.T) {
 		t.Errorf("Expected %s, Got %s", handler.Version, deis.ControllerAPIVersion)
 	}
 
-	if deis.DeisVersion != handler.PlatformVersion {
-		t.Errorf("Expected %s, Got %s", handler.PlatformVersion, deis.DeisVersion)
+	if deis.ControllerVersion != handler.PlatformVersion {
+		t.Errorf("Expected %s, Got %s", handler.PlatformVersion, deis.ControllerVersion)
 	}
 
 	// Make sure the request doesn't modify the URL