Skip to content

Commit 01e07eb

Browse files
author
Matthew Fisher
committed
refactor(systemd): clean up paths
harcoded paths are not required in shell environments. I've also removed unnecessary uses of /bin/sh when we only require an environment variable, since systemd can reference environment variables through ${}. ref: http://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecStart=
1 parent c3ea8eb commit 01e07eb

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

scheduler/coreos.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,10 +199,10 @@ def attach(self, name):
199199
[Service]
200200
ExecStartPre=/usr/bin/docker pull {image}
201201
ExecStartPre=/bin/sh -c "docker inspect {name} >/dev/null 2>&1 && docker rm -f {name} || true"
202-
ExecStart=-/usr/bin/docker run --name {name} -P -e PORT={port} {image} {command}
203-
ExecStartPost=-/bin/sh -c "until docker inspect {name} >/dev/null 2>&1; do sleep 1; done"; \
204-
-/bin/sh -c "arping -Idocker0 -c1 `docker inspect -f '{{{{ .NetworkSettings.IPAddress }}}}' {name}`"
205-
ExecStop=-/usr/bin/docker rm -f {name}
202+
ExecStart=/usr/bin/docker run --name {name} -P -e PORT={port} {image} {command}
203+
ExecStartPost=/bin/sh -c "until docker inspect {name} >/dev/null 2>&1; do sleep 1; done"; \
204+
/bin/sh -c "arping -Idocker0 -c1 `docker inspect -f '{{{{ .NetworkSettings.IPAddress }}}}' {name}`"
205+
ExecStop=/usr/bin/docker rm -f {name}
206206
"""
207207

208208
ANNOUNCE_TEMPLATE = """

systemd/deis-controller.service

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ After=deis-logger.service
66
[Service]
77
EnvironmentFile=/etc/environment
88
TimeoutStartSec=20m
9-
ExecStartPre=/bin/sh -c "/usr/bin/docker history deis/controller >/dev/null || /usr/bin/docker pull deis/controller"
10-
ExecStartPre=/bin/sh -c "/usr/bin/docker inspect deis-controller >/dev/null && /usr/bin/docker rm -f deis-controller || true"
11-
ExecStart=/bin/sh -c "docker run --name deis-controller -p 8000:8000 -e PUBLISH=8000 -e HOST=$COREOS_PRIVATE_IPV4 --volumes-from=deis-logger deis/controller"
9+
ExecStartPre=/bin/sh -c "docker history deis/controller >/dev/null || docker pull deis/controller"
10+
ExecStartPre=/bin/sh -c "docker inspect deis-controller >/dev/null && docker rm -f deis-controller || true"
11+
ExecStart=/usr/bin/docker run --name deis-controller -p 8000:8000 -e PUBLISH=8000 -e HOST=${COREOS_PRIVATE_IPV4} --volumes-from=deis-logger deis/controller
1212
ExecStop=/usr/bin/docker rm -f deis-controller
1313

1414
[Install]

0 commit comments

Comments
 (0)