Skip to content

Commit dab96e5

Browse files
authored
chore(builder): modify config struct (#24)
1 parent b8900c2 commit dab96e5

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ go 1.23
55
require (
66
github.com/aws/aws-sdk-go v1.55.5
77
github.com/distribution/distribution/v3 v3.0.0-beta.1.0.20241022144144-c427f845035d
8-
github.com/drycc/controller-sdk-go v0.0.0-20241122013249-f1d6fea5bf81
8+
github.com/drycc/controller-sdk-go v0.0.0-20241210030451-bd35b03af548
99
github.com/drycc/pkg v0.0.0-20241028091700-8caca001c932
1010
github.com/google/uuid v1.6.0
1111
github.com/kelseyhightower/envconfig v1.4.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ github.com/distribution/distribution/v3 v3.0.0-beta.1.0.20241022144144-c427f8450
2121
github.com/distribution/distribution/v3 v3.0.0-beta.1.0.20241022144144-c427f845035d/go.mod h1:Unn8+BXBntRw4BZHI7UVY9wJ7yGW/xtOspXPxo6hFIs=
2222
github.com/docker/go-metrics v0.0.1 h1:AgB/0SvBxihN0X8OR4SjsblXkbMvalQ8cjmtKQ2rQV8=
2323
github.com/docker/go-metrics v0.0.1/go.mod h1:cG1hvH2utMXtqgqqYE9plW6lDxS3/5ayHzueweSI3Vw=
24-
github.com/drycc/controller-sdk-go v0.0.0-20241122013249-f1d6fea5bf81 h1:y809MASIviVNxzUxP1CDU2EaB5AruRNAiFKjOMCx+0s=
25-
github.com/drycc/controller-sdk-go v0.0.0-20241122013249-f1d6fea5bf81/go.mod h1:F9ViuoVcZ/OG1WnfZBYH6j4v6mb5B+RW9FLaCopADoo=
24+
github.com/drycc/controller-sdk-go v0.0.0-20241210030451-bd35b03af548 h1:eU8e0vViXNIltGCRlIWcNMZ2YCrAkfDtYXaa/wdJI4Q=
25+
github.com/drycc/controller-sdk-go v0.0.0-20241210030451-bd35b03af548/go.mod h1:F9ViuoVcZ/OG1WnfZBYH6j4v6mb5B+RW9FLaCopADoo=
2626
github.com/drycc/pkg v0.0.0-20241028091700-8caca001c932 h1:tUfkfjmFmlm9n0dYp1NoHcFK6+APD/wHZ2We6CKXDSI=
2727
github.com/drycc/pkg v0.0.0-20241028091700-8caca001c932/go.mod h1:upGcZF/RCEqidGjSnWHh/txRC1I4GPsRGvF8/+bDfwU=
2828
github.com/emicklei/go-restful/v3 v3.11.0 h1:rAQeMHw1c7zTmncogyy8VvRZwtkmkZ4FxERmMY4rD+g=

pkg/gitreceive/build_type_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestGetStack(t *testing.T) {
3838
config.Values = []api.ConfigValue{
3939
{
4040
Group: "global",
41-
KV: api.KV{
41+
ConfigVar: api.ConfigVar{
4242
Name: "DRYCC_STACK",
4343
Value: "buildpack",
4444
},
@@ -52,7 +52,7 @@ func TestGetStack(t *testing.T) {
5252
config.Values = []api.ConfigValue{
5353
{
5454
Group: "global",
55-
KV: api.KV{
55+
ConfigVar: api.ConfigVar{
5656
Name: "DRYCC_STACK",
5757
Value: "container",
5858
},

pkg/gitreceive/k8s_util.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,14 @@ func buildJob(
143143
})
144144

145145
if len(job.Spec.Template.Spec.Containers) > 0 {
146-
kvs := []api.KV{}
146+
cvs := []api.ConfigVar{}
147147
// only take the value of the global group
148148
for _, v := range values {
149149
if v.Group == "global" {
150-
kvs = append(kvs, v.KV)
150+
cvs = append(cvs, v.ConfigVar)
151151
}
152152
}
153-
for _, v := range kvs {
153+
for _, v := range cvs {
154154
job.Spec.Template.Spec.Containers[0].Env = append(job.Spec.Template.Spec.Containers[0].Env, corev1.EnvVar{
155155
Name: v.Name,
156156
Value: fmt.Sprintf("%v", v.Value),

pkg/gitreceive/k8s_util_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func TestBuildJob(t *testing.T) {
4949
values := []api.ConfigValue{
5050
{
5151
Group: "global",
52-
KV: api.KV{
52+
ConfigVar: api.ConfigVar{
5353
Name: "KEY",
5454
Value: "VALUE",
5555
},

0 commit comments

Comments
 (0)