Skip to content

Commit c925148

Browse files
author
Aaron Schlesinger
committed
fix(Makefile): speed up all makefile builds
before, we ran ‘glide nv’ before *all* commands, but it was only used in the ‘test’ target. this commit only runs it as part of that target
1 parent 666bb24 commit c925148

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ RC := manifests/deis-${SHORT_NAME}-rc.yaml
2727
SVC := manifests/deis-${SHORT_NAME}-service.yaml
2828
IMAGE := ${DEIS_REGISTRY}${IMAGE_PREFIX}/${SHORT_NAME}:${VERSION}
2929

30-
TEST_PACKAGES := $(shell ${DEV_ENV_CMD} glide nv)
31-
3230
all:
3331
@echo "Use a Makefile to control top-level building of the project."
3432

@@ -46,7 +44,7 @@ build:
4644
@$(call check-static-binary,$(BINARY_DEST_DIR)/boot)
4745

4846
test:
49-
${DEV_ENV_CMD} go test ${TEST_PACKAGES}
47+
${DEV_ENV_CMD} sh -c 'go test $$(glide nv)'
5048

5149
docker-build:
5250
docker build --rm -t ${IMAGE} rootfs

0 commit comments

Comments
 (0)