Merge pull request #502 from lshemesh/fix-env-val-check

mboersma · web-flow · commit c7b88d136c04 · 2017-03-29T09:53:40.000-06:00
fix(gitreceive): fix checkForEnv logic
diff --git a/pkg/gitreceive/k8s_util_test.go b/pkg/gitreceive/k8s_util_test.go
@@ -204,7 +204,7 @@ func checkForEnv(t *testing.T, pod *api.Pod, key, expVal string) {
 	if err != nil {
 		t.Errorf("%v", err)
 	}
-	if val != val {
+	if expVal != val {
 		t.Errorf("expected %v but returned %v ", expVal, val)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ func checkForEnv(t testing.T, pod api.Pod, key, expVal string) {`
`204`	`204`	`if err != nil {`
`205`	`205`	`t.Errorf("%v", err)`
`206`	`206`	`}`
`207`		`- if val != val {`
	`207`	`+ if expVal != val {`
`208`	`208`	`t.Errorf("expected %v but returned %v ", expVal, val)`
`209`	`209`	`}`
`210`	`210`	`}`