ref(build.go,slug_builder_info.go): pass string s3 endpoint to NewSlugBuilderInfo

also add some GoDocs

Author: Aaron Schlesinger

pkg/gitreceive/build.go

@@ -60,7 +60,7 @@ func build(conf *Config, s3Client *s3.S3, builderKey, rawGitSha string) error {
 	}
 	tmpDir := os.TempDir()
 
-	slugBuilderInfo := storage.NewSlugBuilderInfo(s3Client, appName, slugName, gitSha)
+	slugBuilderInfo := storage.NewSlugBuilderInfo(s3Client.Endpoint, appName, slugName, gitSha)
 
 	// Get the application config from the controller, so we can check for a custom buildpack URL
 	appConf, err := getAppConfig(conf, builderKey, conf.Username, appName)

pkg/gitreceive/storage/slug_builder_info.go

@@ -3,26 +3,27 @@ package storage
 import (
 	"fmt"
 
-	"github.com/aws/aws-sdk-go/service/s3"
 	"github.com/deis/builder/pkg/gitreceive/git"
 )
 
+// SlugBuilderInfo contains all of the object storage related information needed to pass to a slug builder
 type SlugBuilderInfo struct {
 	PushKey string
 	PushURL string
 	TarKey  string
 	TarURL  string
 }
 
-func NewSlugBuilderInfo(s3Client *s3.S3, appName, slugName string, gitSha *git.SHA) *SlugBuilderInfo {
+// NewSlugBuilderInfo creates and populates a new SlugBuilderInfo based on the given data
+func NewSlugBuilderInfo(s3Endpoint, appName, slugName string, gitSha *git.SHA) *SlugBuilderInfo {
 	tarKey := fmt.Sprintf("home/%s/tar", slugName)
 	// this is where workflow tells slugrunner to download the slug from, so we have to tell slugbuilder to upload it to here
 	pushKey := fmt.Sprintf("home/%s/push", fmt.Sprintf("%s:git-%s", appName, gitSha.Short))
 
 	return &SlugBuilderInfo{
 		PushKey: pushKey,
-		PushURL: fmt.Sprintf("%s/%s", s3Client.Endpoint, pushKey),
+		PushURL: fmt.Sprintf("%s/%s", s3Endpoint, pushKey),
 		TarKey:  tarKey,
-		TarURL:  fmt.Sprintf("%s/git/%s", s3Client.Endpoint, tarKey),
+		TarURL:  fmt.Sprintf("%s/git/%s", s3Endpoint, tarKey),
 	}
 }