Merge pull request #481 from mboersma/update-go-dev

chore(Makefile): update docker-go-dev to v0.22.0

Author: mboersma

Makefile

@@ -4,7 +4,7 @@ include versioning.mk
 
 # dockerized development environment variables
 REPO_PATH := github.com/deis/${SHORT_NAME}
-DEV_ENV_IMAGE := quay.io/deis/go-dev:0.20.0
+DEV_ENV_IMAGE := quay.io/deis/go-dev:v0.22.0
 DEV_ENV_WORK_DIR := /go/src/${REPO_PATH}
 DEV_ENV_PREFIX := docker run --rm -v ${CURDIR}:${DEV_ENV_WORK_DIR} -w ${DEV_ENV_WORK_DIR}
 DEV_ENV_CMD := ${DEV_ENV_PREFIX} ${DEV_ENV_IMAGE}

pkg/conf/config.go

@@ -15,7 +15,8 @@ const (
 	gcsKey              = "key.json"
 )
 
-var BuilderKeyLocation string = "/var/run/secrets/api/auth/builder-key"
+// BuilderKeyLocation holds the path of the builder key secret.
+var BuilderKeyLocation = "/var/run/secrets/api/auth/builder-key"
 
 // Parameters is map which contains storage params
 type Parameters map[string]interface{}

pkg/gitreceive/build.go

@@ -227,7 +227,7 @@ func build(
 	if err == nil {
 		log.Debug("Pod spec: %v", json)
 	} else {
-		log.Debug("Error creating json representaion of pod spec: %v", err)
+		log.Debug("Error creating json representation of pod spec: %v", err)
 	}
 
 	podsInterface := kubeClient.Pods(conf.PodNamespace)
@@ -290,8 +290,8 @@ func build(
 	}
 	log.Debug("Done")
 
-	procType := deisAPI.ProcessType{}
-	if procType, err = getProcFile(storageDriver, tmpDir, slugBuilderInfo.AbsoluteProcfileKey(), bType); err != nil {
+	procType, err := getProcFile(storageDriver, tmpDir, slugBuilderInfo.AbsoluteProcfileKey(), bType)
+	if err != nil {
 		return err
 	}
 

pkg/gitreceive/slug_builder_info.go

@@ -5,9 +5,11 @@ import (
 )
 
 const (
-	slugTGZName     = "slug.tgz"
+	slugTGZName = "slug.tgz"
+	// CacheKeyPattern is the template for location cache dirs.
 	CacheKeyPattern = "home/%s/cache"
-	GitKeyPattern   = "home/%s:git-%s"
+	// GitKeyPattern is the template for storing git key files.
+	GitKeyPattern = "home/%s:git-%s"
 )
 
 // SlugBuilderInfo contains all of the object storage related information needed to pass to a

pkg/sys/fs_test.go

@@ -9,7 +9,7 @@ import (
 
 const testFilename string = "sys-fs-tests"
 
-var expected []byte = []byte("temporary file's content")
+var expected = []byte("temporary file's content")
 
 func TestRealFS(t *testing.T) {
 	fs := RealFS()