Skip to content

Commit c0b30d1

Browse files
arschlesAaron Schlesinger
authored andcommitted
ref(build.go): prefix all kubectl commands with 'k', use the run func on them
1 parent 41074e4 commit c0b30d1

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

pkg/gitreceive/build.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -303,15 +303,15 @@ func build(conf *Config, builderKey, gitSha string) error {
303303
// kubectl --namespace=${POD_NAMESPACE} create -f /etc/${SLUG_NAME}.yaml >/dev/null
304304

305305
log.Info("Starting build")
306-
kubectlCmd := exec.Command(
306+
kCreateCmd := exec.Command(
307307
"kubectl",
308308
fmt.Sprintf("--namespace=%s", conf.PodNamespace),
309309
"create",
310310
"-f",
311311
fmt.Sprintf("/etc/%s.yaml", slugName),
312312
)
313-
kubectlCmd.Stderr = os.Stderr
314-
if err := kubectlCmd.Run(); err != nil {
313+
kCreateCmd.Stderr = os.Stderr
314+
if err := run(kCreateCmd); err != nil {
315315
return fmt.Errorf("creating builder pod (%s)", err)
316316
}
317317

@@ -324,7 +324,7 @@ func build(conf *Config, builderKey, gitSha string) error {
324324

325325
// poll kubectl every 100ms to determine when the build pod is running
326326
// TODO: use the k8s client and watch the event stream instead (https://github.com/deis/builder/issues/65)
327-
getCmd := exec.Command(
327+
kGetCmd := exec.Command(
328328
"kubectl",
329329
fmt.Sprintf("--namespace=%s", conf.PodNamespace),
330330
fmt.Sprintf("get"),
@@ -335,11 +335,11 @@ func build(conf *Config, builderKey, gitSha string) error {
335335
)
336336
for {
337337
var out bytes.Buffer
338-
getCmd.Stdout = &out
339-
if err := getCmd.Run(); err != nil {
338+
kGetCmd.Stdout = &out
339+
if err := run(kGetCmd); err != nil {
340340
return fmt.Errorf(
341341
"running %s while determining if builder pod %s is running (%s)",
342-
strings.Join(getCmd.Args, " "),
342+
strings.Join(kGetCmd.Args, " "),
343343
buildPodName,
344344
err,
345345
)
@@ -351,16 +351,16 @@ func build(conf *Config, builderKey, gitSha string) error {
351351
}
352352

353353
// get logs from the builder pod
354-
logsCmd := exec.Command(
354+
kLogsCmd := exec.Command(
355355
"kubectl",
356356
fmt.Sprintf("--namespace=%s", conf.PodNamespace),
357357
"logs",
358358
"-f",
359359
buildPodName,
360360
)
361-
logsCmd.Stdout = os.Stdout
362-
if err := logsCmd.Run(); err != nil {
363-
return fmt.Errorf("running %s to get builder logs (%s)", strings.Join(logsCmd.Args, " "), err)
361+
kLogsCmd.Stdout = os.Stdout
362+
if err := run(kLogsCmd); err != nil {
363+
return fmt.Errorf("running %s to get builder logs (%s)", strings.Join(kLogsCmd.Args, " "), err)
364364
}
365365

366366
//

0 commit comments

Comments
 (0)