feat(makefile): add formating and linting tests (#394)

Author: Joshua-Anderson

Makefile

@@ -29,6 +29,11 @@ BINDIR := ./rootfs
 
 DEIS_REGISTRY ?= ${DEV_REGISTRY}/
 
+GO_FILES = $(wildcard *.go)
+GO_PACKAGES := $(shell find pkg -maxdepth 1 -type d)
+GO_PACKAGES_REPO_PATH = $(addprefix $(REPO_PATH)/,$(GO_PACKAGES))
+GOFMT = gofmtresult=$$(gofmt -e -l -s ${GO_FILES} ${GO_PACKAGES}); if [[ -n $$gofmtresult ]]; then echo "gofmt errors found in the following files: $${gofmtresult}"; false; fi;
+
 all:
 	@echo "Use a Makefile to control top-level building of the project."
 
@@ -45,7 +50,16 @@ build:
 	${DEV_ENV_CMD} go build -ldflags ${LDFLAGS} -o ${BINARY_DEST_DIR}/boot boot.go
 	${DEV_ENV_CMD} upx -9 ${BINARY_DEST_DIR}/boot
 
-test:
+test: test-style test-unit
+
+test-style:
+		${DEV_ENV_CMD} bash -c '${GOFMT}'
+		${DEV_ENV_CMD} sh -c 'go vet $(repo_path) $(GO_PACKAGES_REPO_PATH)'
+	@for i in $(addsuffix /...,$(GO_PACKAGES)); do \
+		${DEV_ENV_CMD} golint $$i; \
+	done
+
+test-unit:
 	${DEV_ENV_CMD} sh -c 'go test $$(glide nv)'
 
 test-cover:

pkg/cleaner/cleaner_test.go

@@ -12,8 +12,8 @@ import (
 
 func TestGetDiff(t *testing.T) {
 	nsList := []api.Namespace{
-		api.Namespace{ObjectMeta: api.ObjectMeta{Name: "app1"}},
-		api.Namespace{ObjectMeta: api.ObjectMeta{Name: "app2"}},
+		{ObjectMeta: api.ObjectMeta{Name: "app1"}},
+		{ObjectMeta: api.ObjectMeta{Name: "app2"}},
 	}
 	dirList := []string{"app1", "app3"}
 	diff := getDiff(nsList, dirList)

pkg/gitreceive/build.go

@@ -84,7 +84,7 @@ func build(
 	}
 	defer func() {
 		if err := os.RemoveAll(tmpDir); err != nil {
-			fmt.Errorf("unable to remove tmpdir %s (%s)", tmpDir, err)
+			log.Info("unable to remove tmpdir %s (%s)", tmpDir, err)
 		}
 	}()
 

pkg/gitreceive/config_test.go

@@ -13,11 +13,11 @@ type checkCase struct {
 
 func TestCheckDurations(t *testing.T) {
 	cases := map[checkCase]checkCase{
-		checkCase{100, 300000, 500, 300000}:    checkCase{100, 300000, 500, 300000},
-		checkCase{0, 300000, 500, 300000}:      checkCase{100, 300000, 500, 300000},
-		checkCase{100, 300000, 0, 300000}:      checkCase{100, 300000, 500, 300000},
-		checkCase{300000, 300000, 500, 300000}: checkCase{100, 300000, 500, 300000},
-		checkCase{100, 300000, 300000, 300000}: checkCase{100, 300000, 500, 300000},
+		checkCase{100, 300000, 500, 300000}:    {100, 300000, 500, 300000},
+		checkCase{0, 300000, 500, 300000}:      {100, 300000, 500, 300000},
+		checkCase{100, 300000, 0, 300000}:      {100, 300000, 500, 300000},
+		checkCase{300000, 300000, 500, 300000}: {100, 300000, 500, 300000},
+		checkCase{100, 300000, 300000, 300000}: {100, 300000, 500, 300000},
 	}
 
 	var cnf Config

pkg/gitreceive/k8s_util.go

@@ -114,7 +114,7 @@ func buildPod(
 		Spec: api.PodSpec{
 			RestartPolicy: api.RestartPolicyNever,
 			Containers: []api.Container{
-				api.Container{
+				{
 					ImagePullPolicy: pullPolicy,
 				},
 			},
@@ -139,7 +139,7 @@ func buildPod(
 	})
 
 	pod.Spec.Containers[0].VolumeMounts = []api.VolumeMount{
-		api.VolumeMount{
+		{
 			Name:      objectStore,
 			MountPath: objectStorePath,
 			ReadOnly:  true,

pkg/k8s/pull_policy.go

@@ -10,9 +10,9 @@ var (
 	emptyPullPolicy = api.PullPolicy("")
 	// ValidPullPolicies is the set of pull policies that this package considers valid
 	ValidPullPolicies = map[api.PullPolicy]struct{}{
-		api.PullAlways:       struct{}{},
-		api.PullIfNotPresent: struct{}{},
-		api.PullNever:        struct{}{},
+		api.PullAlways:       {},
+		api.PullIfNotPresent: {},
+		api.PullNever:        {},
 	}
 )