fix(slug_builder_info.go,slug_builder_info_test.go): use proper git sha name for push key

and add tests for it

Author: Aaron Schlesinger

pkg/gitreceive/storage/slug_builder_info.go

@@ -18,7 +18,7 @@ type SlugBuilderInfo struct {
 func NewSlugBuilderInfo(s3Endpoint, appName, slugName string, gitSha *git.SHA) *SlugBuilderInfo {
 	tarKey := fmt.Sprintf("home/%s/tar", slugName)
 	// this is where workflow tells slugrunner to download the slug from, so we have to tell slugbuilder to upload it to here
-	pushKey := fmt.Sprintf("home/%s:git-%s/push", appName, gitSha.Full)
+	pushKey := fmt.Sprintf("home/%s:git-%s/push", appName, gitSha.Full())
 
 	return &SlugBuilderInfo{
 		pushKey: pushKey,

pkg/gitreceive/storage/slug_builder_info_test.go

@@ -29,3 +29,27 @@ func TestS3Endpoint(t *testing.T) {
 		t.Errorf("tar URL %s didn't match expected %s", sbi.TarURL(), expectedTarURL)
 	}
 }
+
+func TestPushKey(t *testing.T) {
+	sha, err := git.NewSha(rawSha)
+	if err != nil {
+		t.Fatalf("error building git sha (%s)", err)
+	}
+	sbi := NewSlugBuilderInfo(s3Endpoint, appName, slugName, sha)
+	expectedPushKey := "home/" + appName + ":git-" + sha.Full() + "/push"
+	if sbi.PushKey() != expectedPushKey {
+		t.Errorf("push key %s didn't match expected %s", sbi.PushKey(), expectedPushKey)
+	}
+}
+
+func TestTarKey(t *testing.T) {
+	sha, err := git.NewSha(rawSha)
+	if err != nil {
+		t.Fatalf("error building git sha (%s)", err)
+	}
+	sbi := NewSlugBuilderInfo(s3Endpoint, appName, slugName, sha)
+	expectedTarKey := "home/" + slugName + "/tar"
+	if sbi.TarKey() != expectedTarKey {
+		t.Errorf("tar key %s didn't match expected %s", sbi.TarKey(), expectedTarKey)
+	}
+}