Merge branch 'master' into git-2-point-8

Author: Matthew Fisher

.gitignore

@@ -2,3 +2,4 @@ rootfs/bin/boot
 vendor/
 rootfs/usr/bin/
 ./builder
+coverage.txt

.travis.yml

@@ -13,4 +13,6 @@ sudo: required
 install:
   - make bootstrap
 script:
-  - make test build docker-build
+  - make test-cover build docker-build
+after_success:
+  - bash <(curl -s https://codecov.io/bash)

Makefile

@@ -7,7 +7,7 @@ export GO15VENDOREXPERIMENT=1
 
 # dockerized development environment variables
 REPO_PATH := github.com/deis/${SHORT_NAME}
-DEV_ENV_IMAGE := quay.io/deis/go-dev:0.12.0
+DEV_ENV_IMAGE := quay.io/deis/go-dev:0.13.0
 DEV_ENV_WORK_DIR := /go/src/${REPO_PATH}
 DEV_ENV_PREFIX := docker run --rm -e GO15VENDOREXPERIMENT=1 -v ${CURDIR}:${DEV_ENV_WORK_DIR} -w ${DEV_ENV_WORK_DIR}
 DEV_ENV_CMD := ${DEV_ENV_PREFIX} ${DEV_ENV_IMAGE}
@@ -41,6 +41,9 @@ build:
 test:
 	${DEV_ENV_CMD} sh -c 'go test $$(glide nv)'
 
+test-cover:
+	${DEV_ENV_CMD} test-cover.sh
+
 update-changelog:
 	${DEV_ENV_PREFIX} -e RELEASE=${WORKFLOW_RELEASE} ${DEV_ENV_IMAGE} gen-changelog.sh \
 	  | cat - CHANGELOG.md > tmp && mv tmp CHANGELOG.md

README.md

@@ -1,8 +1,7 @@
 # Deis Builder v2
 
-[![Build Status](https://travis-ci.org/deis/builder.svg?branch=master)](https://travis-ci.org/deis/builder)
-[![Go Report Card](https://goreportcard.com/badge/github.com/deis/builder)](https://goreportcard.com/report/github.com/deis/builder)
-[![codebeat badge](https://codebeat.co/badges/e29e5e2b-531d-4374-810b-f05053c47688)](https://codebeat.co/projects/github-com-deis-builder) [![Docker Repository on Quay](https://quay.io/repository/deisci/builder/status "Docker Repository on Quay")](https://quay.io/repository/deisci/builder)
+[![Build Status](https://travis-ci.org/deis/builder.svg?branch=master)](https://travis-ci.org/deis/builder) [![codecov.io](https://codecov.io/github/deis/bulder/coverage.svg?branch=master)](https://codecov.io/github/deis/builder?branch=master)
+[![Go Report Card](https://goreportcard.com/badge/github.com/deis/builder)](https://goreportcard.com/report/github.com/deis/builder)[![codebeat badge](https://codebeat.co/badges/e29e5e2b-531d-4374-810b-f05053c47688)](https://codebeat.co/projects/github-com-deis-builder) [![Docker Repository on Quay](https://quay.io/repository/deisci/builder/status "Docker Repository on Quay")](https://quay.io/repository/deisci/builder)
 
 Deis (pronounced DAY-iss) Workflow is an open source Platform as a Service (PaaS) that adds a developer-friendly layer to any [Kubernetes][k8s-home] cluster, making it easy to deploy and manage applications on your own servers.
 

codecov.yml

@@ -0,0 +1,3 @@
+codecov:
+  branch: master
+  slug: "deis/builder"

pkg/sshd/server.go

@@ -255,7 +255,6 @@ func (s *server) answer(channel ssh.Channel, requests <-chan *ssh.Request, conda
 						log.Err("Failed to write to channel: %s", err)
 					}
 					sendExitStatus(1, channel)
-					req.Reply(false, nil)
 					return nil
 				}