fix(pkg/gitreceive/bucket.go): check for BucketAlreadyExists, not 409

Aaron Schlesinger · Aaron Schlesinger · commit 6c45de61f75d · 2016-02-16T13:45:33.000-08:00
the AWS error is “BucketAlreadyExists”, not 409
diff --git a/pkg/gitreceive/storage/bucket.go b/pkg/gitreceive/storage/bucket.go
@@ -6,6 +6,10 @@ import (
 	"github.com/aws/aws-sdk-go/service/s3"
 )
 
+const (
+	bucketAlreadyExistsCode = "BucketAlreadyExists"
+)
+
 var (
 	// ACLPublicRead default ACL for objects in the S3 API compatible storage
 	ACLPublicRead = aws.String("public-read")
@@ -38,7 +42,7 @@ func CreateBucket(svc *s3.S3, bucketName string) error {
 
 	if err != nil {
 		if awsErr, ok := err.(awserr.Error); ok {
-			if awsErr.Code() == "409" {
+			if awsErr.Code() == bucketAlreadyExistsCode {
 				return nil
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,10 @@ import (`
`6`	`6`	`"github.com/aws/aws-sdk-go/service/s3"`
`7`	`7`	`)`
`8`	`8`
	`9`	`+const (`
	`10`	`+ bucketAlreadyExistsCode = "BucketAlreadyExists"`
	`11`	`+)`
	`12`	`+`
`9`	`13`	`var (`
`10`	`14`	`// ACLPublicRead default ACL for objects in the S3 API compatible storage`
`11`	`15`	`ACLPublicRead = aws.String("public-read")`
`@@ -38,7 +42,7 @@ func CreateBucket(svc *s3.S3, bucketName string) error {`
`38`	`42`
`39`	`43`	`if err != nil {`
`40`	`44`	`if awsErr, ok := err.(awserr.Error); ok {`
`41`		`- if awsErr.Code() == "409" {`
	`45`	`+ if awsErr.Code() == bucketAlreadyExistsCode {`
`42`	`46`	`return nil`
`43`	`47`	`}`
`44`	`48`	`}`