fix(pkg/sshd): move utility func to common file

Author: Aaron Schlesinger

pkg/sshd/common_test.go

@@ -0,0 +1,26 @@
+package sshd
+
+import (
+	"errors"
+	"sync"
+	"time"
+)
+
+var (
+	errWGTimedOut = errors.New("waitgroup wait timed out")
+)
+
+// waitWithTimeout waits for wg.Done() until timeout expires. returns errWGTimedOut if timeout expired before wg.Done() returned, otherwise returns nil. this func is naturally leaky if wg.Done() never returns
+func waitWithTimeout(wg *sync.WaitGroup, timeout time.Duration) error {
+	ch := make(chan struct{})
+	go func() {
+		defer close(ch)
+		wg.Wait()
+	}()
+	select {
+	case <-time.After(timeout):
+		return errWGTimedOut
+	case <-ch:
+		return nil
+	}
+}

pkg/sshd/lock_test.go

@@ -1,7 +1,6 @@
 package sshd
 
 import (
-	"errors"
 	"sync"
 	"testing"
 	"time"
@@ -13,25 +12,6 @@ const (
 	callbackTimeout = 1 * time.Second
 )
 
-var (
-	errWGTimedOut = errors.New("waitgroup wait timed out")
-)
-
-// waitWithTimeout waits for wg.Done() until timeout expires. returns errWGTimedOut if timeout expired before wg.Done() returned, otherwise returns nil. this func is naturally leaky if wg.Done() never returns
-func waitWithTimeout(wg *sync.WaitGroup, timeout time.Duration) error {
-	ch := make(chan struct{})
-	go func() {
-		defer close(ch)
-		wg.Wait()
-	}()
-	select {
-	case <-time.After(timeout):
-		return errWGTimedOut
-	case <-ch:
-		return nil
-	}
-}
-
 func TestMultipleSameRepoLocks(t *testing.T) {
 	var wg sync.WaitGroup
 	const repo = "repo1"