Skip to content

Commit 5be2e94

Browse files
committed
Merge pull request #355 from kmala/clean
ref(k8s): update k8s api to 1.2.4
2 parents 026e7e7 + 79d61c0 commit 5be2e94

8 files changed

Lines changed: 182 additions & 94 deletions

File tree

glide.lock

Lines changed: 98 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

glide.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ import:
1616
version: eca94c41d994ae2215d455ce578ae6e2dc6ee516
1717
- package: github.com/pborman/uuid
1818
- package: github.com/deis/pkg
19-
version: 7f41ea6de942139d5de67f4d4cb2cccced991f6f
19+
version: 189ed6bd6b6aa6629b72c2c5472095e176eec8a6
2020
subpackages:
2121
- time
2222
- log
2323
- package: github.com/codegangsta/cli
2424
version: a65b733b303f0055f8d324d805f393cd3e7a7904
2525
- package: k8s.io/kubernetes
26-
version: ~1.1
26+
version: 1.2.4
2727
- package: github.com/arschles/assert
2828
version: 6882f85ccdc7c1822b146d1a6b0c2c48f91b5140
2929
- package: github.com/docker/distribution

pkg/cleaner/cleaner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func dirHasGitSuffix(dir string) bool {
8484
// On any error, it uses log messages to output a human readable description of what happened.
8585
func Run(gitHome string, nsLister k8s.NamespaceLister, fs sys.FS, pollSleepDuration time.Duration) error {
8686
for {
87-
nsList, err := nsLister.List(labels.Everything(), fields.Everything())
87+
nsList, err := nsLister.List(api.ListOptions{LabelSelector: labels.Everything(), FieldSelector: fields.Everything()})
8888
if err != nil {
8989
log.Printf("Cleaner error listing namespaces (%s)", err)
9090
continue

pkg/gitreceive/build.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,14 +183,19 @@ func build(
183183
return fmt.Errorf("creating builder pod (%s)", err)
184184
}
185185

186-
if err := waitForPod(kubeClient, newPod.Namespace, newPod.Name, conf.SessionIdleInterval(), conf.BuilderPodTickDuration(), conf.BuilderPodWaitDuration()); err != nil {
186+
pw := k8s.NewPodWatcher(kubeClient, "deis")
187+
stopCh := make(chan struct{})
188+
defer close(stopCh)
189+
go pw.Controller.Run(stopCh)
190+
191+
if err := waitForPod(pw, newPod.Namespace, newPod.Name, conf.SessionIdleInterval(), conf.BuilderPodTickDuration(), conf.BuilderPodWaitDuration()); err != nil {
187192
return fmt.Errorf("watching events for builder pod startup (%s)", err)
188193
}
189194

190195
req := kubeClient.Get().Namespace(newPod.Namespace).Name(newPod.Name).Resource("pods").SubResource("log").VersionedParams(
191196
&api.PodLogOptions{
192197
Follow: true,
193-
}, api.Scheme)
198+
}, api.ParameterCodec)
194199

195200
rc, err := req.Stream()
196201
if err != nil {
@@ -213,7 +218,7 @@ func build(
213218
)
214219
// check the state and exit code of the build pod.
215220
// if the code is not 0 return error
216-
if err := waitForPodEnd(kubeClient, newPod.Namespace, newPod.Name, conf.BuilderPodTickDuration(), conf.BuilderPodWaitDuration()); err != nil {
221+
if err := waitForPodEnd(pw, newPod.Namespace, newPod.Name, conf.BuilderPodTickDuration(), conf.BuilderPodWaitDuration()); err != nil {
217222
return fmt.Errorf("error getting builder pod status (%s)", err)
218223
}
219224
log.Debug("Done")

0 commit comments

Comments
 (0)