fix(boot.go,pkg/sshd/config.go): refactor config

the envconfig time.Duration support doesn’t seem to work properly, so
take in an integer seconds and convert it

Author: Aaron Schlesinger

boot.go

@@ -72,7 +72,7 @@ func main() {
 				log.Printf("Starting deleted app cleaner")
 				cleanerErrCh := make(chan error)
 				go func() {
-					if err := cleaner.Run(gitHomeDir, kubeClient.Namespaces(), deleteLock, cnf.CleanerPollSleepDuration); err != nil {
+					if err := cleaner.Run(gitHomeDir, kubeClient.Namespaces(), deleteLock, cnf.CleanerPollSleepDuration()); err != nil {
 						cleanerErrCh <- err
 					}
 				}()

pkg/sshd/config.go

@@ -6,9 +6,13 @@ import (
 
 // Config represents the required SSH server configuration
 type Config struct {
-	SSHHostIP                  string        `envconfig:"SSH_HOST_IP" default:"0.0.0.0" required:"true"`
-	SSHHostPort                int           `envconfig:"SSH_HOST_PORT" default:"2223" required:"true"`
-	HealthSrvPort              int           `envconfig:"HEALTH_SERVER_PORT" default:"8092"`
-	HealthSrvTestStorageRegion string        `envconfig:"HEALTH_SERVER_TEST_STORAGE_REGION" default:"us-east-1"`
-	CleanerPollSleepDuration   time.Duration `envconfig:"CLEANER_POLL_SLEEP_DURATION" default:"1s"`
+	SSHHostIP                   string `envconfig:"SSH_HOST_IP" default:"0.0.0.0" required:"true"`
+	SSHHostPort                 int    `envconfig:"SSH_HOST_PORT" default:"2223" required:"true"`
+	HealthSrvPort               int    `envconfig:"HEALTH_SERVER_PORT" default:"8092"`
+	HealthSrvTestStorageRegion  string `envconfig:"HEALTH_SERVER_TEST_STORAGE_REGION" default:"us-east-1"`
+	CleanerPollSleepDurationSec int    `envconfig:"CLEANER_POLL_SLEEP_DURATION_SEC" default:"1"`
+}
+
+func (c Config) CleanerPollSleepDuration() time.Duration {
+	return time.Duration(c.CleanerPollSleepDurationSec) * time.Second
 }