Skip to content

Commit 40949cf

Browse files
author
Aaron Schlesinger
committed
doc(pkg/gitreceive/storage/client.go): add comment about guessing the signature version
1 parent a61255c commit 40949cf

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

pkg/gitreceive/storage/client.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ func GetClient(regionStr string, fs sys.FS, env sys.Env) (*Client, error) {
2222
return nil, err
2323
}
2424

25+
// the New function call guesses which signature version to use. Currently, it correctly guesses V2 for GCS and V4 for both AWS S3 and Minio
2526
s3Client, err := s3.New(endpoint.URLStr, auth.accessKeyID, auth.accessKeySecret, false)
2627
if err != nil {
2728
return nil, err

0 commit comments

Comments
 (0)