fix(pkg/gitreceive/storage): make AbsoluteSlugURL point to the right place

previously it was using AbsoluteSlugObjectKey, which caused a repeat of
the bucket name and push key prefix

Author: Aaron Schlesinger

pkg/gitreceive/storage/slug_builder_info.go

@@ -38,5 +38,5 @@ func (s SlugBuilderInfo) TarKey() string                { return s.tarKey }
 func (s SlugBuilderInfo) TarURL() string                { return s.tarURL }
 func (s SlugBuilderInfo) AbsoluteSlugObjectKey() string { return s.PushKey() + "/" + slugTGZName }
 func (s SlugBuilderInfo) AbsoluteSlugURL() string {
-	return s.PushURL() + "/" + s.AbsoluteSlugObjectKey()
+	return s.PushURL() + "/" + slugTGZName
 }

pkg/gitreceive/storage/slug_builder_info_test.go

@@ -70,5 +70,5 @@ func TestAbsoluteSlugURL(t *testing.T) {
 	sha, err := git.NewSha(rawSha)
 	assert.NoErr(t, err)
 	sbi := NewSlugBuilderInfo(s3Endpoint, bucket, appName, slugName, sha)
-	assert.Equal(t, sbi.AbsoluteSlugURL(), sbi.PushURL()+"/"+sbi.PushKey()+"/"+slugTGZName, "absolute slug URL")
+	assert.Equal(t, sbi.AbsoluteSlugURL(), sbi.PushURL()+"/"+slugTGZName, "absolute slug URL")
 }