Skip to content

Commit 31a9511

Browse files
arschlesAaron Schlesinger
authored andcommitted
fix(boot.go,git.go): use cookoo logging for debug logs
instead of mixing and matching
1 parent ec7b88b commit 31a9511

2 files changed

Lines changed: 14 additions & 13 deletions

File tree

boot.go

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ import (
44
"os"
55
"runtime"
66

7+
cookoolog "github.com/Masterminds/cookoo/log"
78
"github.com/codegangsta/cli"
89
"github.com/deis/builder/fetcher"
910
"github.com/deis/builder/pkg"
1011
"github.com/deis/builder/pkg/conf"
1112
"github.com/deis/builder/pkg/gitreceive"
12-
"github.com/deis/builder/pkg/log"
13+
pkglog "github.com/deis/builder/pkg/log"
1314
"github.com/deis/builder/pkg/sshd"
1415
)
1516

@@ -24,9 +25,10 @@ func init() {
2425

2526
func main() {
2627
if os.Getenv("DEBUG") == "true" {
27-
log.IsDebugging = true
28+
pkglog.IsDebugging = true
29+
cookoolog.Level = cookoolog.LogDebug
2830
}
29-
log.Debug("Running in debug mode")
31+
pkglog.Debug("Running in debug mode")
3032

3133
app := cli.NewApp()
3234

@@ -38,12 +40,12 @@ func main() {
3840
Action: func(c *cli.Context) {
3941
cnf := new(sshd.Config)
4042
if err := conf.EnvConfig(serverConfAppName, cnf); err != nil {
41-
log.Err("getting config for %s [%s]", serverConfAppName, err)
43+
pkglog.Err("getting config for %s [%s]", serverConfAppName, err)
4244
os.Exit(1)
4345
}
44-
log.Info("starting fetcher on port %d", cnf.FetcherPort)
46+
pkglog.Info("starting fetcher on port %d", cnf.FetcherPort)
4547
go fetcher.Serve(cnf.FetcherPort)
46-
log.Info("starting SSH server on %s:%d", cnf.SSHHostIP, cnf.SSHHostPort)
48+
pkglog.Info("starting SSH server on %s:%d", cnf.SSHHostIP, cnf.SSHHostPort)
4749
os.Exit(pkg.Run(cnf.SSHHostIP, cnf.SSHHostPort, "boot"))
4850
},
4951
},
@@ -54,11 +56,11 @@ func main() {
5456
Action: func(c *cli.Context) {
5557
cnf := new(gitreceive.Config)
5658
if err := conf.EnvConfig(gitReceiveConfAppName, cnf); err != nil {
57-
log.Err("Error getting config for %s [%s]", gitReceiveConfAppName, err)
59+
pkglog.Err("Error getting config for %s [%s]", gitReceiveConfAppName, err)
5860
os.Exit(1)
5961
}
6062
if err := gitreceive.Run(cnf); err != nil {
61-
log.Err("running git receive hook [%s]", err)
63+
pkglog.Err("running git receive hook [%s]", err)
6264
os.Exit(1)
6365
}
6466
},

pkg/git/git.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717

1818
"github.com/Masterminds/cookoo"
1919
"github.com/Masterminds/cookoo/log"
20-
pkglog "github.com/deis/builder/pkg/log"
2120
"golang.org/x/crypto/ssh"
2221
)
2322

@@ -62,7 +61,7 @@ func Receive(c cookoo.Context, p *cookoo.Params) (interface{}, cookoo.Interrupt)
6261
fingerprint := p.Get("fingerprint", nil).(string)
6362
user := p.Get("user", "").(string)
6463

65-
pkglog.Debug("receiving git repo name: %s, operation: %s, fingerprint: %s, user: %s", repoName, operation, fingerprint, user)
64+
log.Debugf(c, "receiving git repo name: %s, operation: %s, fingerprint: %s, user: %s", repoName, operation, fingerprint, user)
6665

6766
repo, err := cleanRepoName(repoName)
6867
if err != nil {
@@ -90,8 +89,8 @@ func Receive(c cookoo.Context, p *cookoo.Params) (interface{}, cookoo.Interrupt)
9089
}
9190
cmd.Env = append(cmd.Env, os.Environ()...)
9291

93-
pkglog.Debug("Working Dir: %s", cmd.Dir)
94-
pkglog.Debug("Environment: %s", strings.Join(cmd.Env, ","))
92+
log.Debugf(c, "Working Dir: %s", cmd.Dir)
93+
log.Debugf(c, "Environment: %s", strings.Join(cmd.Env, ","))
9594

9695
plumbCommand(cmd, channel, &errbuff)
9796

@@ -179,7 +178,7 @@ func createRepo(c cookoo.Context, repoPath, gitHome string) (bool, error) {
179178
}
180179

181180
writePath := filepath.Join(repoPath, "hooks", "pre-receive")
182-
pkglog.Debug("Writing pre-receive hook to %s", writePath)
181+
log.Debugf(c, "Writing pre-receive hook to %s", writePath)
183182
if err := ioutil.WriteFile(writePath, hookByteBuf.Bytes(), 0755); err != nil {
184183
return false, fmt.Errorf("Cannot write pre-receive hook to %s (%s)", writePath, err)
185184
}

0 commit comments

Comments
 (0)