Merge pull request #184 from arschles/bucket-create-errs

fix(gitreceive/storage/bucket.go): silence bucket creation errors

Author: arschles

pkg/gitreceive/storage/bucket.go

@@ -6,28 +6,15 @@ import (
 	"github.com/aws/aws-sdk-go/service/s3"
 )
 
+const (
+	bucketAlreadyExistsCode = "BucketAlreadyExists"
+)
+
 var (
 	// ACLPublicRead default ACL for objects in the S3 API compatible storage
 	ACLPublicRead = aws.String("public-read")
 )
 
-// BucketExists returns if a bucket exists in the S3 API compatible storage
-func BucketExists(svc *s3.S3, bucketName string) (bool, error) {
-	_, err := svc.HeadBucket(&s3.HeadBucketInput{
-		Bucket: aws.String(bucketName),
-	})
-	if err != nil {
-		if awsErr, ok := err.(awserr.Error); ok {
-			if awsErr.Code() == "404" {
-				return false, nil
-			}
-		}
-
-		return false, err
-	}
-	return true, nil
-}
-
 // CreateBucket creates a new bucket in the S3 API compatible storage or
 // return an error in case the bucket already exists
 func CreateBucket(svc *s3.S3, bucketName string) error {
@@ -38,7 +25,7 @@ func CreateBucket(svc *s3.S3, bucketName string) error {
 
 	if err != nil {
 		if awsErr, ok := err.(awserr.Error); ok {
-			if awsErr.Code() == "409" {
+			if awsErr.Code() == bucketAlreadyExistsCode {
 				return nil
 			}
 		}