Skip to content

Commit 11869e8

Browse files
committed
Merge pull request #174 from arschles/consolidate-run
ref(rootfs/Dockerfile): consolidate RUN command
2 parents 953145b + ba8a65f commit 11869e8

1 file changed

Lines changed: 19 additions & 20 deletions

File tree

rootfs/Dockerfile

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,17 @@ FROM alpine:3.3
33
# install git and configure gituser
44
ENV GITHOME /home/git
55
ENV GITUSER git
6+
# this is so the minio client (https://github.com/minio/mc) works properly
7+
ENV DOCKERIMAGE=1
8+
ENV DEIS_BUILDER_SERVER_FETCHER_PORT=3000
9+
ENV DEIS_BUILDER_SERVER_SSH_HOST_IP=0.0.0.0
10+
ENV DEIS_BUILDER_SERVER_SSH_HOST_PORT=2223
611

7-
# install common packages
12+
EXPOSE 2223
13+
EXPOSE 3000
14+
15+
# install common packages, install & configure the SSH server, and set up directories, users & perms.
16+
# NOTE: $GITUSER is added to docker group to use docker without sudo and to slug group in order to share resources with the slug user
817
RUN apk add --update-cache \
918
bash \
1019
sudo \
@@ -13,28 +22,18 @@ RUN apk add --update-cache \
1322
coreutils \
1423
tar \
1524
xz \
16-
&& rm -rf /var/cache/apk/*
17-
18-
# install & configure the SSH server, then set up directories, users and perms.
19-
# NOTE: $GITUSER is added to docker group to use docker without sudo and to slug group in order to share resources with the slug user
20-
RUN mkdir -p /var/run/sshd && rm -rf /etc/ssh/ssh_host* \
21-
&& mkdir /apps \
22-
&& adduser -D -h $GITHOME $GITUSER \
23-
&& mkdir -p $GITHOME/.ssh && chown git:git $GITHOME/.ssh \
24-
&& chown -R $GITUSER:$GITUSER $GITHOME \
25-
&& addgroup -g 2000 slug && adduser -D -u 2000 -G slug slug \
26-
&& addgroup $GITUSER slug \
27-
&& passwd -u git
25+
&& rm -rf /var/cache/apk/* \
26+
&& mkdir -p /var/run/sshd && rm -rf /etc/ssh/ssh_host* \
27+
&& mkdir /apps \
28+
&& adduser -D -h $GITHOME $GITUSER \
29+
&& mkdir -p $GITHOME/.ssh && chown git:git $GITHOME/.ssh \
30+
&& chown -R $GITUSER:$GITUSER $GITHOME \
31+
&& addgroup -g 2000 slug && adduser -D -u 2000 -G slug slug \
32+
&& addgroup $GITUSER slug \
33+
&& passwd -u git
2834

2935
COPY . /
3036

31-
# this is so the minio client (https://github.com/minio/mc) works properly
32-
ENV DOCKERIMAGE=1
3337
ENV DEIS_RELEASE 2.0.0-dev
34-
ENV DEIS_BUILDER_SERVER_FETCHER_PORT=3000
35-
ENV DEIS_BUILDER_SERVER_SSH_HOST_IP=0.0.0.0
36-
ENV DEIS_BUILDER_SERVER_SSH_HOST_PORT=2223
3738

3839
ENTRYPOINT ["boot", "server"]
39-
EXPOSE 2223
40-
EXPOSE 3000

0 commit comments

Comments
 (0)