ref(gitreceive): remove push hook (#407)

It was used for authorization, but the keys hook is now used for both authentication and authorization

Author: Joshua-Anderson

pkg/gitreceive/build.go

@@ -16,7 +16,6 @@ import (
 	"github.com/deis/builder/pkg/k8s"
 	"github.com/deis/builder/pkg/storage"
 	"github.com/deis/builder/pkg/sys"
-	"github.com/deis/controller-sdk-go"
 	deisAPI "github.com/deis/controller-sdk-go/api"
 	"github.com/deis/controller-sdk-go/hooks"
 	"github.com/deis/pkg/log"
@@ -47,7 +46,6 @@ func run(cmd *exec.Cmd) error {
 }
 
 func build(
-	client *deis.Client,
 	conf *Config,
 	storageDriver storagedriver.StorageDriver,
 	kubeClient *client.Client,
@@ -94,6 +92,11 @@ func build(
 
 	slugBuilderInfo := NewSlugBuilderInfo(slugName)
 
+	client, err := controller.New()
+	if err != nil {
+		return err
+	}
+
 	// Get the application config from the controller, so we can check for a custom buildpack URL
 	appConf, err := hooks.GetAppConfig(client, conf.Username, appName)
 	if controller.CheckAPICompat(client, err) != nil {

pkg/gitreceive/run.go

@@ -7,9 +7,7 @@ import (
 	"strings"
 
 	builderconf "github.com/deis/builder/pkg/conf"
-	"github.com/deis/builder/pkg/controller"
 	"github.com/deis/builder/pkg/sys"
-	"github.com/deis/controller-sdk-go/hooks"
 	"github.com/deis/pkg/log"
 	storagedriver "github.com/docker/distribution/registry/storage/driver"
 
@@ -50,19 +48,9 @@ func Run(conf *Config, fs sys.FS, env sys.Env, storageDriver storagedriver.Stora
 
 		log.Debug("read [%s,%s,%s]", oldRev, newRev, refName)
 
-		client, err := controller.New()
-		if err != nil {
-			return err
-		}
-
-		if err := hooks.CreatePush(client, conf.Username, conf.App(), newRev, conf.Fingerprint,
-			conf.SSHConnection, conf.SSHOriginalCommand); err != nil {
-			return err
-		}
-
 		// if we're processing a receive-pack on an existing repo, run a build
 		if strings.HasPrefix(conf.SSHOriginalCommand, "git-receive-pack") {
-			if err := build(client, conf, storageDriver, kubeClient, fs, env, builderKey, newRev); err != nil {
+			if err := build(conf, storageDriver, kubeClient, fs, env, builderKey, newRev); err != nil {
 				return err
 			}
 		}