fix(clean): mistake delete new resource service

Author: jianxiaoguo

build.sh

@@ -150,7 +150,7 @@ def update(self,
             raise ErrBadRequest(
                 msg="Instance %s does not updateable" % instance_id)
         allow_paras = get_addon_allow_paras(details.service_id)
-        logger.debug(f"service instance update parameters: {details.parameters}")
+        logger.debug(f"service instance update parameters: {details.parameters}")  # noqa
         not_allow_keys = verify_parameters(allow_paras, details.parameters)
         if not_allow_keys:
             raise ErrBadRequest(

rootfs/helmbroker/broker.py

@@ -6,7 +6,6 @@
 from openbrokerapi.service_broker import OperationState
 
 from .config import INSTANCES_PATH
-from .tasks import deprovision
 from .utils import get_instance_file, load_instance_meta
 
 logger = logging.getLogger(__name__)
@@ -21,10 +20,6 @@ def clean_instance():
             interval = time.time() - data["last_modified_time"]
             state = data["last_operation"]["state"]
             operation = data["last_operation"]["operation"]
-            if interval > 3600 * 24 and (
-                operation == "deprovision"
-                    and state != OperationState.SUCCEEDED):
-                deprovision.delay(instance_id)
             if operation == "deprovision":
                 if state == OperationState.SUCCEEDED or (
                     interval > 3600 * 24

rootfs/helmbroker/cleaner.py

@@ -79,7 +79,7 @@ def update(instance_id: str, details: UpdateDetails):
         # remove the key which value is null
         data['details']['parameters'] = {k: v for k, v in paras.items() if v != ""}  # noqa
     data['last_operation']["state"] = OperationState.IN_PROGRESS.value
-    data['last_operation']["description"] = "update %s in progress at %s" % (instance_id, time.time())
+    data['last_operation']["description"] = "update %s in progress at %s" % (instance_id, time.time())  # noqa
     dump_instance_meta(instance_id, data)
     chart_path = get_chart_path(instance_id)
     values_file = os.path.join(get_plan_path(instance_id), "values.yaml")

rootfs/helmbroker/tasks.py

@@ -111,7 +111,7 @@ def dump_addon_values(service_id, instance_id):
         with open(f'{CONFIG_PATH}/addon-values', 'r') as f:
             addon_values = yaml.load(f.read(), Loader=yaml.Loader)
             f.write(yaml.dump(
-                addon_values.get(service["name"], {}).get(service["version"], {})
+                addon_values.get(service["name"], {}).get(service["version"], {})  # noqa
             ))
     return file